Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label for delayed unassigned shards #311

Conversation

therealdwright
Copy link
Contributor

@therealdwright therealdwright commented Jun 9, 2021

Closes #310

This has been tested on my Elasticsearch 7.13.0 cluster deployed using ECK. I have now got unique metrics for unassigned shards and delayed unassigned shards. These can be queried in prometheus using:

avg(es_cluster_shards_number{cluster="example",type="unassigned"})

and

avg(es_cluster_shards_number{cluster="example",type="delayed_unassigned"})

I've also produced a simple dashboard that works for the current metrics/labels. Please let me know if you want this PR'ed in to the repo.

@therealdwright therealdwright force-pushed the delayed-unassigned-shards branch 7 times, most recently from 8619392 to b679149 Compare June 16, 2021 02:30
@therealdwright therealdwright force-pushed the delayed-unassigned-shards branch from b679149 to c108785 Compare July 11, 2021 22:26
@therealdwright
Copy link
Contributor Author

Hi @lukas-vlcek and @vvanholl,

I'm wondering if there is any appetite to merge this (very) minor change? We would like to use the upstream repository rather than a fork and this is the only thing that is in the way.

Thanks.

@therealdwright
Copy link
Contributor Author

Hello @lukas-vlcek and @vvanholl,

Could you please let me know if this is something that your project does not wish to accept? I'll close the PR if this is the case.

@lukas-vlcek
Copy link
Collaborator

@therealdwright Do not close it please.
I will review asap.

@therealdwright therealdwright force-pushed the delayed-unassigned-shards branch from 89c35fb to b83da1e Compare October 12, 2021 06:51
@therealdwright
Copy link
Contributor Author

Hello @lukas-vlcek and @vvanholl,

I'd like to again ask for an update please. Does this PR have any chance of being merged?

@therealdwright
Copy link
Contributor Author

Closing as it does not seem there is any interest in this PR.

@mindw
Copy link

mindw commented Jun 6, 2022

@therealdwright a friendly fork of this repo with the above change (and many others) is maintained by me at https://github.com/mindw/elasticsearch-prometheus-exporter FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support delayed_unassigned metric
3 participants